ArcEmu: Is It Just Me Or This Needs To Be Rewritten? - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Is It Just Me Or This Needs To Be Rewritten? taken from Player.cpp

#1 User is offline   lexythelord 

  • Member
  • Pip
  • Group: Members
  • Posts: 40
  • Joined: 23-December 10
  • Gender:Male

Posted 09 July 2014 - 03:00 AM

void Player::RepopAtGraveyard(float ox, float oy, float oz, uint32 mapid)
{
	bool first = true;
	// float closestX = 0, closestY = 0, closestZ = 0, closestO = 0;
	StorageContainerIterator<GraveyardTeleport> * itr;

	LocationVector src(ox, oy, oz);
	LocationVector dest;
	LocationVector temp;
	float closest_dist = 999999.0f;
	float dist;

	if(m_bg && m_bg->HookHandleRepop(this))
	{
		return;
	}
	else
	{
		itr = GraveyardStorage.MakeIterator();
		GraveyardTeleport* pGrave = NULL;
		while(!itr->AtEnd())
		{
			pGrave = itr->Get();
			if(pGrave->MapId == mapid && (pGrave->FactionID == GetTeam() || pGrave->FactionID == 3))
			{
				temp.ChangeCoords(pGrave->X, pGrave->Y, pGrave->Z);
				dist = src.DistanceSq(temp);
				if(first || dist < closest_dist)
				{
					first = false;
					closest_dist = dist;
					dest = temp;
				}
			}

			if(!itr->Inc())
				break;
		}
		/* Fix on 3/13/2010, defaults to last graveyard, if none fit the criteria.
		Keeps the player from hanging out to dry.*/
		if(first && pGrave != NULL)//crappy Databases with no graveyards.
		{
			dest.ChangeCoords(pGrave->X, pGrave->Y, pGrave->Z);
			first = false;
		}

		itr->Destruct();
	}

	if(sHookInterface.OnRepop(this) && !first)//dest has now always a value != {0,0,0,0}//but there may be DBs with no graveyards
	{
		SafeTeleport(mapid, 0, dest);
	}

	/* Todo: Generate error message here, compensate for failed teleport. */

//	//correct method as it works on official server, and does not require any damn sql
//	//no factions! no zones! no sqls! 1word: blizz-like
//	float closestX , closestY , closestZ ;
//	uint32 entries=sWorldSafeLocsStore.GetNumRows();
//	GraveyardEntry*g;
//	uint32 mymapid=mapid
//	float mx=ox,my=oy;
//	float last_distance=9e10;
//
//	for(uint32 x= 0;x<entries;x++)
//	{
//		g=sWorldSafeLocsStore.LookupEntry(x);
//		if(g->mapid!=mymapid)continue;
//		float distance=(mx-g->x)*(mx-g->x)+(my-g->y)*(my-g->y);
//		if(distance<last_distance)
//		{
//			closestX=g->x;
//			closestY=g->y;
//			closestZ=g->z;
//			last_distance=distance;
//		}
//
//
//	}
//	if(last_distance<1e10)
//#endif


}

0

#2 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 09 July 2014 - 06:30 AM

What's wrong with it and why don't you rewrite it, if it needs a rewrite?
"The demand for free goods is infinite."
0

#3 User is offline   lexythelord 

  • Member
  • Pip
  • Group: Members
  • Posts: 40
  • Joined: 23-December 10
  • Gender:Male

Posted 09 July 2014 - 08:37 AM

Do you hate me because I am romanian? Or do you hate everyone?

It's not hate... It's just... You don't like noobs.
0

#4 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 09 July 2014 - 11:23 AM

View Postlexythelord, on 09 July 2014 - 08:37 AM, said:

Do you hate me because I am romanian? Or do you hate everyone?

It's not hate... It's just... You don't like noobs.

I don't hate anyone, I simply asked 2 questions.
So again, why is it wrong? What's wrong with it?
Once we've established that, the next question arises: Why don't you rewrite it then?
"The demand for free goods is infinite."
0

#5 User is offline   Tulba 

  • Member
  • Pip
  • Group: Members
  • Posts: 29
  • Joined: 21-November 11
  • Gender:Male
  • Location:Switzerland
  • Server OS:Windows

Posted 07 August 2014 - 11:48 AM

@ lexythelord: No its not "You don't like noobs."! It is more like "If it needs to be rewritten, start rewriting it".
0

#6 User is offline   Obsent 

  • Member
  • Pip
  • Group: Members
  • Posts: 11
  • Joined: 06-January 09

Posted 07 August 2014 - 09:48 PM

Tulba, what are you doing at these forums? It`s completely dead.
0

#7 User is offline   Tulba 

  • Member
  • Pip
  • Group: Members
  • Posts: 29
  • Joined: 21-November 11
  • Gender:Male
  • Location:Switzerland
  • Server OS:Windows

Posted 08 August 2014 - 07:47 AM

Just because everyone says "it's dead" it is not dead.

Maybe give it a chance to become more alive :P
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users