ArcEmu: Fix Building Arcemu With Visualstudio 11 - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Read:

When submitting patches - READ: http://arcemu.org/fo...?showtopic=2355 -
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Fix Building Arcemu With Visualstudio 11 Fixes compile errors related to VisualStudio 11

#1 User is offline   Artox 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 142
  • Joined: 01-November 08

Posted 21 May 2012 - 07:28 AM

What this Patch does:
It sets the VisualStudio compiler heap limit to 300 which is required to do a win64 debug build.
And it enables /bigobj for VisualStudio 11 no matter wether it is building for win32 or win64.

Maybe the cmake_required_version needs increasing in order to make sure the MSVC11 variable is set correctly.
UPDATE: We need cmake 2.8.6 at minimum. It introduced the ability to find VS11.
UPDATE: heap limit must be 400. Patch is not updated for this, do it manually!

diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt
index 7cfdefb..7872109 100644
--- a/cmake/CMakeLists.txt
+++ b/cmake/CMakeLists.txt
@@ -1,6 +1,6 @@
 project(Arcemu)
 
-cmake_minimum_required(VERSION 2.8)
+cmake_minimum_required(VERSION 2.8.6)
 #Do system checking.
 
 SET( GLOBAL_DEFINES "-DHAVE_CONFIG_H")
@@ -14,11 +14,13 @@ IF( CMAKE_SYSTEM_PROCESSOR MATCHES "[xX]64" OR CMAKE_SYSTEM_PROCESSOR MATCHES "[
 	#define for 64bit
 	SET( GLOBAL_DEFINES ${GLOBAL_DEFINES} -"DX64")
 	SET( IS_64BIT TRUE)
-	IF( CMAKE_GENERATOR MATCHES Visual* OR CMAKE_GENERATOR MATCHES NMake*)
-		SET( GLOBAL_DEFINES ${GLOBAL_DEFINES} "-bigobj")
-	ENDIF()
 ENDIF()
 
+#on windows /bigobj is needed for x64 and for all vs11 builds
+IF( WIN32 AND (IS_64BIT OR MSVC11) )
+	SET( GLOBAL_DEFINES ${GLOBAL_DEFINES} "-bigobj")
+ENDIF( WIN32 AND (IS_64BIT OR MSVC11) )
+
 #mac osx
 IF( APPLE )
 	SET( GLOBAL_DEFINES ${GLOBAL_DEFINES} "-DHAVE_DARWIN")
@@ -67,7 +69,7 @@ ENDIF( WIN32 )
 SET(ARCEMU_SCRIPTLIB_PATH "modules" CACHE PATH "The directory which contains the 'lib' directory that has the script libraries." )
 SET(BUILD_ARCEMUSCRIPTS TRUE CACHE BOOL "Set to false to NOT build script libraries." )
 SET(BUILD_TOOLS TRUE CACHE BOOL "Build Arcemu tools" )
-SET(VISUALSTUDIO_COMPILERHEAPLIMIT 200 CACHE STRING "Visual Studio compiler heap limit. Ignore on darwin and unix platforms." )
+SET(VISUALSTUDIO_COMPILERHEAPLIMIT 300 CACHE STRING "Visual Studio compiler heap limit. Ignore on darwin and unix platforms." )
 
 include(CompilerVersion)
 if( CMAKE_GENERATOR MATCHES Unix* )
Attached File  vs11.patch (1.53K)
Number of downloads: 7
Posted Image
3

#2 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 21 May 2012 - 11:36 AM

visual studio 11 hasn't been released, but thanks.
Posted Image
Posted Image
Sorry for my bad english
0

#3 User is offline   Artox 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 142
  • Joined: 01-November 08

Posted 21 May 2012 - 11:46 AM

View Postsanctum32, on 21 May 2012 - 11:36 AM, said:

visual studio 11 hasn't been released, but thanks.


True, but the Beta is out which enables everybody to use it.
Posted Image
0

#4 User is offline   Ceterrec 

  • Member
  • Pip
  • Group: Members
  • Posts: 54
  • Joined: 16-March 12
  • Gender:Male
  • Location:Germany
  • Server OS:Windows

Posted 12 August 2012 - 08:10 AM

Look at this: http://arcemu.org/fo...showtopic=26428

I think this patch should be implemented because every time someone tries to compile ArcEmu in x64 Debug mode he'll fail and went to the forum to ask for help.

Tested the patch (with VS10 x86 RelWithDebInfo build): works great!

An advice:
Please use the git command line to create patch files the next time. When you use the git gui it creates patches that contain no author information and commit descriptions, it simply logs the changes. The one, who'll add this patch, will have to recreate your commit. ... Or better, simply submit a pull request.
0

#5 User is offline   Artox 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 142
  • Joined: 01-November 08

Posted 09 October 2012 - 01:29 PM

View PostCeterrec, on 12 August 2012 - 08:10 AM, said:

Look at this: http://arcemu.org/fo...showtopic=26428

I think this patch should be implemented because every time someone tries to compile ArcEmu in x64 Debug mode he'll fail and went to the forum to ask for help.

Tested the patch (with VS10 x86 RelWithDebInfo build): works great!

An advice:
Please use the git command line to create patch files the next time. When you use the git gui it creates patches that contain no author information and commit descriptions, it simply logs the changes. The one, who'll add this patch, will have to recreate your commit. ... Or better, simply submit a pull request.


I personally like those patches with no message and no author stuff. And the person applying then is free to choose *any* commit message.

This patch needs heap limit 400 now for Visual Studio 11, according to my latest tests. Otherwise this patch should be pretty fine now that VS11 is really there and not beta.
Posted Image
0

#6 User is offline   YuckFou 

  • Member
  • Pip
  • Group: Members
  • Posts: 13
  • Joined: 01-October 12
  • Gender:Male
  • Location:The Netherlands.
  • Server OS:Windows

Posted 13 October 2012 - 03:26 AM

I use VS2011 (2012 RC) and none else due to it's high functionality and for building projects I can hardly find any bug.
I do recommend that this gets supported with ArcEmu as it will attract much people and make them happy, like me ;-).
There is by the way already an open-pull request on GitHub here:
https://github.com/a...arcemu/pull/290
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users