[sanctum32]

My english isn't good but i'll try to explain about project.

ArcScripts2 - is fork of old arcemu scripts with motivation to increase Game Objects/Units AI work more blizzlike. Development runs on ai_agents, npc_monstersay and on c++ scripts. As base old arcemu c++ scripts development is slow, it is main reason why i have created it, also and improve c++ knowledge.
It live aproximatelly from 2011 april month.

In ArcScripts2 has been added these things:

• All libralies has been moved to one
  
• Have ai_agents and npc_monstersay developments
  
• A bit of cleaned up old code
  
• Few icc scripts and similar scripts.
  
• Reordered scripts
  
• Changed base scripts source structure (not code)
  
• Some whyscripts and eclipse project scripts (they made few great)

-Soonish there will implemented new class constructor called ArcScripts2 which will contain data loads and similar (almost finished loadscripttexts, need only to finish gettextdata function)

All development is under GPL license, but if you have interested to help to improve development of scripts, leave message in this topic.
main requirements are c++ knowledge, sql programming knowledge.

Repository: git://github.com/arcscripts2/arcscripts2.git
https://github.com/a...ts2/arcscripts2

History: https://github.com/a...commits/master/

PS: at this moment i'm doing small reorganise of scripts...
it will finished in few days.

[THCSphere]

Sounds like what you're trying to do is create a ArcEmu version of ScriptDev2.

[sanctum32]

no, but taking some ideas from sd2

Script datas are really useful from sd2 side for example - multilanguage support can be added more easer in scripts.

One lib as base takes less resources...
also is easer to handle additional actions and no need multiply it on every lib - it is possible, like as load_instance_texts, load_extra_scripts_texts and etc, but just damn...

[THCSphere]

sanctum32, on 07 December 2011 - 11:04 AM, said:

no, but taking some ideas from sd2

Script datas are really useful from sd2 side for example - multilanguage support can be added more easer in scripts.

One lib as base takes less resources...
also is easer to handle additional actions and no need multiply it, as base it is possible.

Caching more database content uses more memory.

[sanctum32]

yes, but as base, it takes aprox 15-20mb more of ram so, it is not very critical...
i have mean about current load of script texts.

[dfighter]

I wouldn't mind if there was a peer reviewed scripting project for Arcemu, that way we could focus on core functionality and features instead of contents
However I don't mean this as an offense but Sanctum32 has a lot to learn, each and every patch of his were majorly flawed so I'd be cautious with his work.

[sanctum32]

dfighter, old times are old...

[THCSphere]

sanctum32, on 07 December 2011 - 12:30 PM, said:

dfighter, old times are old...

Can you explain GetHealthPercent() <= 25.0f o.o

[jackpoz]

https://github.com/a...fe587ed3dacbb97

Quote

jackpoz commented on 1f12aa7

November 17, 2011

scripts/InstanceScripts/Raid_IcecrownCitadel.cpp line 375

bool BoneStorm(uint32 i, Spell* s)
{
    if(s->u_caster == NULL)
        return true;
    SpellEntry* pSpell;
    if(s)
        pSpell = dbcSpell.LookupEntry((uint32)s);

first deref s with s->u_caster, then check if s is NULL and if it's not it casts s (which is a pointer to a Spell class) to uint32 and pass it to LookupEntry() as spell id. Very bugged code.

I don't want to be mean but you should learn how C++ and ArcEmu work before starting a huge project like this. The "dbcSpell.LookupEntry((uint32)s)" part is one of the worst thing I've ever seen in any ArcEmu related code, it means you have absolutely no idea what you were doing there.

[sanctum32]

ah, i tired to repeat and repeat, look in current code...
and i know, what i'm doing...

[jackpoz]

could you then explain why you casted "s" to uint32 and passed it to dbcSpell.LookupEntry() ?

[sanctum32]

dbcSpell.LookupEntry(uint32 /*value*/); //function argument is uint32 variable type...

[jackpoz]

And what is the result of casting "s", a pointer to SpellEntry struct, to uint32? Is this what LookupEntry() expects as value?

[Sdyess94]

I'm not sure about the spell class but if you're going to cast the pointer, you should at least deref it?

[sanctum32]

THCSphere, on 07 December 2011 - 12:54 PM, said:

Can you explain GetHealthPercent() <= 25.0f o.o

if you know mathematic as well, then you should understand...

for example, 465*0.18 = 83.7... just read http://en.wikipedia....wiki/Percentage

talking about bonestorm spell, it has been updated and removed these misstakes, anyway, inspected, how trully spellhandlers works... had bad info, thats it.

[THCSphere]

sanctum32, on 08 December 2011 - 01:17 PM, said:

if you know mathematic as well, then you should understand...

for example, 465*0.18 = 83.7... just read http://en.wikipedia....wiki/Percentage

talking about bonestorm spell, it has been updated and removed these misstakes, anyway, inspected, how trully spellhandlers works... had bad info, thats it.

That's not what I meant. Why are you comparing a GetHealthPct(), which is a int32 value, to 25.0f, which is a float value. That is what I wanted you to explain. There was no need for any of the changes you made like that o.o

[jackpoz]

THCSphere, on 08 December 2011 - 05:23 PM, said:

That's not what I meant. Why are you comparing a GetHealthPct(), which is a int32 value, to 25.0f, which is a float value. That is what I wanted you to explain. There was no need for any of the changes you made like that o.o

Nice observation, someone checking the prototype of a function when reading/using it. I like this post, I like your attitude

[THCSphere]

jackpoz, on 08 December 2011 - 06:05 PM, said:

Nice observation, someone checking the prototype of a function when reading/using it. I like this post, I like your attitude

It's a must for anyone who takes developing seriously.

[sanctum32]

i already did answer, read +100 times, maybe you'll get...
about last posts - lol

i changed it to float, because logically it should be as float... i'm not children teacher who willl teach word "percentage" btw, gethealthpercent has been changed, so basically it returns float.

[jackpoz]

Could you provide an example where you needed it to be float instead of integer?