ArcEmu: [Applied][rogue] Overkill - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied][rogue] Overkill

#1 User is offline   Neo_mat 

  • drunken bear rider
  • PipPipPip
  • Group: Developers
  • Posts: 278
  • Joined: 07-June 08
  • Gender:Male
  • Server OS:Linux

Posted 29 November 2011 - 07:53 PM

Rogue:
- Overkill, now properly refreshing duration after leaving and entering stealth again.
- Removed useless itr for Vanish stealth spell cast.
From b892ed702314d92b86d47a84ba58d5136f8600f1 Mon Sep 17 00:00:00 2001
From: Neo_mat <neomat.github@gmail.com>
Date: Wed, 30 Nov 2011 04:50:49 +0400
Subject: [PATCH] Rogue: Overkill, now properly refreshing duration after
 leaving and entering stealth again.

Removed useless itr for Vanish stealth spell cast.
---
 src/arcemu-world/SpellAuras.cpp |   28 +++++++++++++---------------
 1 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/src/arcemu-world/SpellAuras.cpp b/src/arcemu-world/SpellAuras.cpp
index 91b8823..eced2e5 100644
--- a/src/arcemu-world/SpellAuras.cpp
+++ b/src/arcemu-world/SpellAuras.cpp
@@ -2679,9 +2679,16 @@ void Aura::SpellAuraModStealth(bool apply)
 {
 	if(apply)
 	{
-		//Overkill must proc only if we aren't already stealthed
-		if(!m_target->IsStealth() && m_target->HasAurasWithNameHash(SPELL_HASH_OVERKILL))
+		//Overkill must proc only if we aren't already stealthed, also refreshing duration.
+		if(!m_target->IsStealth() && m_target->HasAura(58426))
 		{
+			Aura *buff = m_target->FindAura(58427);
+			if(buff)
+			{
+				m_target->SetAurDuration(58427, -1);
+				m_target->ModVisualAuraStackCount(buff, 0);
+			}
+			else
 			m_target->CastSpell(m_target, 58427, true);
 		}
 
@@ -2755,21 +2762,10 @@ void Aura::SpellAuraModStealth(bool apply)
 				}
 			}
 
-			// check for stealth spells
+			// Cast stealth spell/dismount/drop BG flag
 			if(p_target != NULL)
 			{
-				uint32 stealth_id = 0;
-				SpellSet::iterator itr = p_target->mSpells.begin();
-				SpellSet::iterator end = p_target->mSpells.end();
-				for(; itr != end; ++itr)
-				{
-					if(((*itr) == 1787 || (*itr) == 1786 || (*itr) == 1785 || (*itr) == 1784) && stealth_id < (*itr))
-					{
-						stealth_id = *itr;
-					}
-				}
-				if(stealth_id != 0)
-					p_target->CastSpell(p_target, dbcSpell.LookupEntry(stealth_id), true);
+				p_target->CastSpell( p_target, 1784, true );
 
 				p_target->Dismount();
 
@@ -2823,6 +2819,8 @@ void Aura::SpellAuraModStealth(bool apply)
 
 					m_target->m_auras[x]->SetDuration(tmp_duration);
 
+					sEventMgr.ModifyEventTimeLeft(m_target->m_auras[x], EVENT_AURA_REMOVE, tmp_duration);
+					m_target->ModVisualAuraStackCount(m_target->m_auras[x], 0);
 					sEventMgr.AddEvent(m_target->m_auras[x], &Aura::Remove, EVENT_AURA_REMOVE, tmp_duration, 1, EVENT_FLAG_DO_NOT_EXECUTE_IN_WORLD_CONTEXT | EVENT_FLAG_DELETES_OBJECT);
 				}
 			}
-- 
1.7.7.1.msysgit.0

Attached File(s)


Posted Image
Posted Image
Posted Image
I am 91% addicted to World of Warcraft. What about you?
0

#2 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 25 January 2012 - 01:20 PM

- Applied.
- Moved to applied patches.
"The demand for free goods is infinite."
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users