ArcEmu: [Applied]Spells With Proc_on_gain_experience - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied]Spells With Proc_on_gain_experience

#1 User is offline   Neo_mat 

  • drunken bear rider
  • PipPipPip
  • Group: Developers
  • Posts: 278
  • Joined: 07-June 08
  • Gender:Male
  • Server OS:Linux

Posted 13 November 2011 - 09:47 AM

General:
- Spells with PROC_ON_GAIN_EXPIERIENCE are working properly now. Even if you are level 80 you still should get a proc if you are killing a unit that is in level range for experience or honor for you. (72 lvl is min level that you can get exp/honor from) (Spirit Tap, Remorseless Attacks and others.)

Misc:

- Clean up in HackFixes.cpp and Spell.cpp, removed Blackout assign to shadow school (spell doesn't exist in game anymore) and removed Blackout with Mace Specialization talent assign from Diminishing Returns in Spell.cpp. Mace Specialization is no longer RNG stun talent if you are using 2H Mace, so no point in keeping it there.



From 3e1b16931af87f2940add6a65374eb501136d809 Mon Sep 17 00:00:00 2001
From: Neo_mat
Date: Sat, 12 Nov 2011 09:01:42 +0400
Subject: [PATCH] General: Spells with PROC_ON_GAIN_EXPIERIENCE are working
 properly now. Even if you are level 80 you still should get
 a proc if you are killing a unit that is in level range for
 experience or honor for you. (72 lvl is min level that you
 can get exp/honor from) (Spirit Tap, Remorseless Attacks
 and others.)

Misc: Clean up in HackFixes.cpp and Spell.cpp, removed Blackout assign to shadow school (spell doesn't exist in game anymore) and removed Blackout with Mace Specialization talent assign from Diminishing Returns in Spell.cpp. Mace Specialization is no longer RNG stun talent if you are using 2H Mace, so no point in keeping it there.
---
 src/arcemu-world/HackFixes.cpp |    5 -----
 src/arcemu-world/Player.cpp    |    8 +++++---
 src/arcemu-world/Spell.cpp 	|    2 --
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/arcemu-world/HackFixes.cpp b/src/arcemu-world/HackFixes.cpp
index c4a80c4..d0b01bd 100644
--- a/src/arcemu-world/HackFixes.cpp
+++ b/src/arcemu-world/HackFixes.cpp
@@ -771,11 +771,6 @@ void ApplyNormalFixes()
 		{
 			sp->School = SCHOOL_FROST;
 		}
-		// Blackout handled by Shadow school
-		else if(strstr(sp->Name, "Blackout"))
-		{
-			sp->School = SCHOOL_SHADOW;
-		}
 		//more triggered spell ids are wrong. I think blizz is trying to outsmart us :S
 		//Chain Heal all ranks %50 heal value (49 + 1)
 		else if(strstr(sp->Name, "Chain Heal"))
diff --git a/src/arcemu-world/Player.cpp b/src/arcemu-world/Player.cpp
index d141b31..fa0d890 100644
--- a/src/arcemu-world/Player.cpp
+++ b/src/arcemu-world/Player.cpp
@@ -1588,9 +1588,6 @@ void Player::GiveXP(uint32 xp, const uint64 & guid, bool allowbonus)
 	// Set the update bit
 	SetXp(newxp);
 
-	HandleProc(PROC_ON_GAIN_EXPIERIENCE, this, NULL);
-	m_procCounter = 0;
-
 }
 
 void Player::smsg_InitialSpells()
@@ -12590,6 +12587,11 @@ void Player::DealDamage(Unit* pVictim, uint32 damage, uint32 targetEvent, uint32
 				GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_KILLING_BLOW, GetMapId(), 0, 0);
 #endif
 
+				if( pVictim->getLevel() >= (getLevel()-8) && ( GetGUID() != pVictim->GetGUID() ) )
+				{
+					HandleProc(PROC_ON_GAIN_EXPIERIENCE, this, NULL);
+					m_procCounter = 0;
+				}
 			}
 		}
 
diff --git a/src/arcemu-world/Spell.cpp b/src/arcemu-world/Spell.cpp
index 3a6ee61..d31acf1 100644
--- a/src/arcemu-world/Spell.cpp
+++ b/src/arcemu-world/Spell.cpp
@@ -5590,8 +5590,6 @@ uint32 GetDiminishingGroup(uint32 NameHash)
 		case SPELL_HASH_STARFIRE_STUN:
 		case SPELL_HASH_STONECLAW_STUN:
 		case SPELL_HASH_STUN:					// Generic ones
-		case SPELL_HASH_BLACKOUT:
-		case SPELL_HASH_MACE_SPECIALIZATION:		// Mace Specialization
 			{
 				grp = DIMINISHING_GROUP_STUN_PROC;
 				pve = true;
-- 
1.7.7.1.msysgit.0


Any feedback? Would like to have discussions about patches, because feeling like no one cares about community patches anymore :P

Attached File(s)


Posted Image
Posted Image
Posted Image
I am 91% addicted to World of Warcraft. What about you?
0

#2 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 13 November 2011 - 11:29 AM

View PostNeo_mat, on 13 November 2011 - 09:47 AM, said:

Any feedback? Would like to have discussions about patches, because feeling like no one cares about community patches anymore :P

We've had a discussion about another topic last night on IRC + I merged and fixed a pull request....
That's hardly not caring :P
"The demand for free goods is infinite."
0

#3 User is offline   Neo_mat 

  • drunken bear rider
  • PipPipPip
  • Group: Developers
  • Posts: 278
  • Joined: 07-June 08
  • Gender:Male
  • Server OS:Linux

Posted 13 November 2011 - 11:36 AM

View Postdfighter, on 13 November 2011 - 11:29 AM, said:

We've had a discussion about another topic last night on IRC + I merged and fixed a pull request....
That's hardly not caring :P


Well yeah, just meant not the mainteners of core, just users to test and respond with any feedback, suggestions, etc ^^.
Posted Image
Posted Image
Posted Image
I am 91% addicted to World of Warcraft. What about you?
0

#4 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 13 November 2011 - 01:34 PM

View PostNeo_mat, on 13 November 2011 - 11:36 AM, said:

Well yeah, just meant not the mainteners of core, just users to test and respond with any feedback, suggestions, etc ^^.

You have to realize that most people here can barely set up and run Arcemu, let alone test and review patches....
"The demand for free goods is infinite."
0

#5 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 25 January 2012 - 01:19 PM

- Applied.
- Moved to applied patches.
"The demand for free goods is infinite."
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users