ArcEmu: [Applied][rogue] Cold Blood And Clean Up In Unit.cpp - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied][rogue] Cold Blood And Clean Up In Unit.cpp

#1 User is offline   Neo_mat 

  • drunken bear rider
  • PipPipPip
  • Group: Developers
  • Posts: 278
  • Joined: 07-June 08
  • Gender:Male
  • Server OS:Linux

Posted 11 November 2011 - 12:15 AM

Rogue: Cold Blood is no longer abusable and is properly fading after casting "offensive" spells, currently it might not fade after casting Mutilate/Ambush and you can keep getting 100% crits from these abilities, but it can fade after casting defensive spells like Vanish/Gouge, that should not happen.

Misc: Cleaned up in Unit.cpp:
- Find Weakness was replaced in WoTLK by 3 ranks talent instead of 5 ranks, it now increases offensive abilities damage by % instead of finishing moves increasing offensive abilities damage by % for 10 sec.

- Blackout, no longer in Shadow Talents tree and spell ID 15269 is no longer presented in DBC.

- Shadowguard, is not presented in DBC.


From 3e95f5c260efccb6dab8bba8b9b272f4b1d5155f Mon Sep 17 00:00:00 2001
From: Neo_mat
Date: Fri, 11 Nov 2011 09:10:32 +0400
Subject: [PATCH] Rogue: Cold Blood is no longer abusable and is properly
 fading after casting "offensive" spells, currently it might
 not fade after casting Mutilate/Ambush and you can keep
 getting 100% crits from these abilities, but it can fade
 after casting defensive spells like Vanish/Gouge.

Misc: Cleaned up in Unit.cpp:
- Find Weakness was replaced in WoTLK by 3 ranks talent instead of 5 ranks, it now increases offensive abilities damage by % instead of finishing moves increasing offensive abilities damage by % for 10 sec.

- Blackout, no longer in Shadow Talents tree and spell ID 15269 is no longer presented in DBC.

- Shadowguard, is not presented in DBC.
---
 src/arcemu-world/HackFixes.cpp |    9 ---------
 src/arcemu-world/Unit.cpp      |   37 +------------------------------------
 2 files changed, 1 insertions(+), 45 deletions(-)

diff --git a/src/arcemu-world/HackFixes.cpp b/src/arcemu-world/HackFixes.cpp
index fd7bb4c..c4a80c4 100644
--- a/src/arcemu-world/HackFixes.cpp
+++ b/src/arcemu-world/HackFixes.cpp
@@ -631,8 +631,6 @@ void ApplyNormalFixes()
 						pr |= PROC_ON_MELEE_ATTACK | static_cast<uint32>(PROC_TARGET_SELF);
 					if(strstr(sp->Description, "experience or honor"))
 						pr |= PROC_ON_GAIN_EXPIERIENCE;
-					if(strstr(sp->Description, "your next offensive ability"))
-						pr |= PROC_ON_CAST_SPELL;
 					if(strstr(sp->Description, "hit by a melee or ranged attack"))
 						pr |= PROC_ON_MELEE_ATTACK_VICTIM | PROC_ON_RANGED_ATTACK_VICTIM;
 					if(strstr(sp->Description, "enemy strikes the caster"))
@@ -647,8 +645,6 @@ void ApplyNormalFixes()
 						pr |= PROC_ON_CRIT_ATTACK | PROC_ON_SPELL_CRIT_HIT;
 					if(strstr(sp->Description, "shadow bolt critical strikes increase shadow damage"))
 						pr |= PROC_ON_SPELL_CRIT_HIT;
-					if(strstr(sp->Description, "next offensive ability"))
-						pr |= PROC_ON_CAST_SPELL;
 					if(strstr(sp->Description, "after being hit with a shadow or fire spell"))
 						pr |= PROC_ON_SPELL_LAND_VICTIM;
 					if(strstr(sp->Description, "giving each melee attack"))
@@ -3069,11 +3065,6 @@ void ApplyNormalFixes()
 	if(sp != NULL)
 		sp->AttributesEx |= ATTRIBUTESEX_NOT_BREAK_STEALTH;
 
-	// Rogue - Cold Blood (Interrupt Flag)
-	sp = CheckAndReturnSpellEntry(14177);
-	if(sp != NULL)
-		sp->AuraInterruptFlags |= AURA_INTERRUPT_ON_AFTER_CAST_SPELL;
-
 	/* Rogue - Improved Expose Armor (rank 1)
 	sp = CheckAndReturnSpellEntry( 14168 );
 	if(sp != NULL)
diff --git a/src/arcemu-world/Unit.cpp b/src/arcemu-world/Unit.cpp
index ad48b8f..9ccc2eb 100644
--- a/src/arcemu-world/Unit.cpp
+++ b/src/arcemu-world/Unit.cpp
@@ -1877,41 +1877,6 @@ uint32 Unit::HandleProc(uint32 flag, Unit* victim, SpellEntry* CastingSpell, boo
 							continue;
 					}
 					break;
-					//rogue - Find Weakness
-				case 31234:
-				case 31235:
-				case 31236:
-				case 31237:
-				case 31238:
-					{
-						if(CastingSpell == NULL)
-							continue;//this should not occur unless we made a fuckup somewhere
-						if(!(CastingSpell->c_is_flags & SPELL_FLAG_IS_FINISHING_MOVE))
-							continue;
-					}
-					break;
-					//Priest - Shadowguard
-				case 28377:
-				case 28378:
-				case 28379:
-				case 28380:
-				case 28381:
-				case 28382:
-				case 28385:
-					{
-						if(CastingSpell && (this == victim || !(CastingSpell->c_is_flags & SPELL_FLAG_IS_DAMAGING)))       //no self casts allowed or beneficial spells
-							continue;//we can proc on ranged weapons too
-					}
-					break;
-					//Priest - blackout
-				case 15269:
-					{
-						if(CastingSpell == NULL)
-							continue;//this should not occur unless we made a fuckup somewhere
-						if(CastingSpell->School != SCHOOL_SHADOW || !(CastingSpell->c_is_flags & SPELL_FLAG_IS_DAMAGING))
-							continue;
-					}
-					break;
 					//warrior - improved berserker rage
 				case 23690:
 				case 23691:
@@ -2535,7 +2500,7 @@ uint32 Unit::HandleProc(uint32 flag, Unit* victim, SpellEntry* CastingSpell, boo
 							break;
 						case 14177: // Cold blood will get removed on offensive spell
 							{
-								if(CastingSpell == NULL || CastingSpell->Id == 36554 || victim == this || isFriendly(this, victim))
+								if(!(CastingSpell->SpellGroupType[0] & 0x6820206 || CastingSpell->SpellGroupType[1] & 0x240009))
 									continue;
 							}
 							break;
-- 
1.7.7.1.msysgit.0

Attached File(s)


Posted Image
Posted Image
Posted Image
I am 91% addicted to World of Warcraft. What about you?
0

#2 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 25 January 2012 - 01:18 PM

- Applied.
- Moved to applied patches.
"The demand for free goods is infinite."
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users