ArcEmu: [Applied][fix, Cleanup]deadmines - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied][fix, Cleanup]deadmines

#1 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 17 May 2011 - 05:31 AM

created on arcemu r4200

basically it does not fix canon event, just added only that on canon activate, gates will opened by fire

moved NPCs (642,643,644,1763) OnDeath event to instance script.

added objects 101832 (RhahkZor gates lever), 101833 (Sneed gates lever), 101834 (Gilnid gates lever), 16398(Defias canon) in instance script.
removed creature scripts of these npcs (596, 599, 626, 1729, 4417, 636, 642, 643, 1763, 647, 645) due them CreatureAI can be completed by database and removed object script (16398, basically it was moved to instance script).

http://pastebin.com/PFwFEUzc - V1
https://gist.github.com/1153851 - V2 (added all levers, added missing vanchief emotes, added all doors handling on bosses death) + updated to latest revision (plain script for review https://gist.github.com/1139364)

EDIT:
-- Brainwashed Noble
update creature_proto set auras='12544' where entry=596;
delete from ai_agents where entry=596;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (596, 4, 4, 0, 25, 0, 512, 3, 1, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (596, 4, 4, 0, 30, 0, 9053, 8, 2, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (596, 4, 4, 0, 25, 0, 228, 11, 1, 0, 0, 0);

-- Marisa du'Paige
delete from ai_agents where entry=599;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (599, 4, 4, 0, 30, 0, 9053, 8, 2, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (599, 4, 4, 0, 25, 0, 512, 3, 1, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (599, 4, 4, 0, 25, 0, 228, 11, 1, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (599, 4, 4, 0, 25, 0, 700, 3, 1, 0, 0, 0);

-- Foreman Thistlenettle
delete from ai_agents where entry=626;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (626, 4, 4, 0, 30, 0, 5219, 8, 2, 0, 0, 0);

-- Defias Evoker
update creature_proto set auras='12544' where entry=1729;
delete from ai_agents where entry=1729;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (1729, 4, 4, 0, 30, 0, 11829, 8, 1, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (1729, 4, 4, 0, 30, 0, 4979, 10, 4, 0, 0, 0);

-- Defias Taskmaster (author: whydb)
delete from ai_agents where entry=4417;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (4417, 4, 4, 2, 100, 0, 6660, 8, 1, 20000, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (4417, 4, 4, 2, 100, 0, 6685, 8, 1, 35000, 0, 0);

-- Defias Blackguard
update creature_proto set auras='6408' where entry=636;

-- Sneed's Shredder <Lumbermaster>
delete from ai_agents where entry=642;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (642, 4, 4, 0, 30, 0, 3603, 11, 2, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (642, 4, 4, 0, 30, 0, 7399, 4, 2, 0, 0, 0);

-- Sneed <Lumbermaster>
delete from ai_agents where entry=643;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (643, 4, 4, 0, 30, 0, 6713, 11, 2, 0, 0, 0);

-- Gilnid <The Smelter>
delete from ai_agents where entry=1763;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (1763, 4, 4, 0, 30, 0, 5213, 8, 2, 0, 0, 0);

-- Captain Greenskin
delete from ai_agents where entry=647;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (647, 4, 4, 0, 30, 0, 40505, 8, 2, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (647, 4, 4, 0, 20, 0, 4208, 11, 2, 0, 0, 0);

-- Cookie <The Ship's Cook>
delete from ai_agents where entry=645;
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (645, 4, 4, 0, 30, 0, 5174, 2, 4, 0, 0, 0);
INSERT INTO `ai_agents` (`entry`, `instance_mode`, `type`, `event`, `chance`, `maxcount`, `spell`, `spelltype`, `targettype_overwrite`, `cooldown_overwrite`, `floatMisc1`, `Misc2`) VALUES (645, 4, 4, 0, 25, 0, 6306, 11, 1, 0, 0, 0);

This post has been edited by sanctum32: 27 August 2011 - 02:23 PM

Posted Image
Posted Image
Sorry for my bad english
0

#2 User is offline   Datastream1 

  • Member
  • Pip
  • Group: Members
  • Posts: 87
  • Joined: 15-April 09
  • Gender:Male
  • Location:the great US&A
  • Server OS:Other

Posted 30 May 2011 - 10:38 AM

View Postsanctum32, on 17 May 2011 - 05:31 AM, said:

basically it does not fix canon event, just added only that on canon activate, gates will opened by fire
CreatureAI can be completed by database


why not fix that cannon? o:!
ill look into it for you because im bored shitless atm :)

for the creature AI you should give the sql, unless thats up to the DB teams and im missing that o0? other then that nice job :o
Posted Image
need halp with a C++ script? message me! :P
0

#3 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 08 June 2011 - 05:03 AM

i can't make work temporally, due my pc has problems with motherboard.
i'll continue it after june 14 th! because i will get new strong hardware at this day.

about sql, it will not big problem.

EDIT:
updated patch, look into V2,
cannon event basically can't be called, because just don't know, how correctly call Instance UpdateEvent stuff (this is required for it).

This post has been edited by sanctum32: 24 August 2011 - 10:18 AM

Posted Image
Posted Image
Sorry for my bad english
0

#4 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 25 August 2011 - 11:12 AM

View Postsanctum32, on 08 June 2011 - 05:03 AM, said:

EDIT:
updated patch, look into V2,
cannon event basically can't be called, because just don't know, how correctly call Instance UpdateEvent stuff (this is required for it).

Can't you just change the state of the door when using the canon?
"The demand for free goods is infinite."
0

#5 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 25 August 2011 - 05:26 PM

i have updated patch v2 (gist), fixed typos.
http://www.youtube.c...h?v=brNQ4SzMYQk - old deadmines video, it shows, how it SHOULD to work. Cannon event still is missing (it will released soonish)
Posted Image
Posted Image
Sorry for my bad english
0

#6 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 26 August 2011 - 02:06 AM

Alright I've just finished checking how the current one works, and I will check your changes today sometime.


EDIT:

You didn't initialize the GUIDs in DeadminesInstanceScript. So with an empty or bugged DB, those will be random numbers.
The very least the script won't work, but also it might set the state of another GO in the instance this way. ( because it's a random value, it can be another GO's GUID )

The original RhahkZorAI, SneedAI, GilnidAI scripts spawned some patrolling NPCs on death, your scripts don't.
Are they not needed anymore?

Also you left
AddSpell(6304, Target_Current, 8, 0, 3);

in there in RhahkZorAI . This could have been moved to ai_agents too, couldn't it?

Same with
AddSpell(SMITE_SLAM, Target_Current, 25, 0.0f, 15, 0.0f, 8.0f, true);

in MrSmiteAI

and VanCleefAI
AddSpell(3391, Target_Self, 25, 0, 0);	//Thrash (Gives the caster 2 extra attacks.)


Also in your enum you enumerated Mr. Smite's Id with the label NPC_MR_SMITH... Was this supposed to be a script for Matrix Online or something? :P
"The demand for free goods is infinite."
0

#7 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 26 August 2011 - 08:24 AM

ah, typo typo typo... :P

i left AddSpell, because just not tested/don't know, does script works with ai_agents data, i have mean, c++ script + ai_agents.

about names: yeah, it is very big typo on smite :D

Guids are getting by entry, i have checked, i have added positions for these objects, which can be more than 1 in same instance.
and it was tested and i see no problems ingame, just it shouldn't add another random guids...

updated only enum atm, other things temporally leaving.
Posted Image
Posted Image
Sorry for my bad english
0

#8 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 26 August 2011 - 11:27 AM

View Postsanctum32, on 26 August 2011 - 08:24 AM, said:

i left AddSpell, because just not tested/don't know, does script works with ai_agents data, i have mean, c++ script + ai_agents.

Well don't be lazy next time :P

View Postsanctum32, on 26 August 2011 - 08:24 AM, said:

Guids are getting by entry, i have checked, i have added positions for these objects, which can be more than 1 in same instance.
and it was tested and i see no problems ingame, just it shouldn't add another random guids...

I don't think you get the problem. What if you don't have those GOs ( either or neither of them ) spawned in the DB?
What do you think the the guid variables will contain then? ( without initializing them )

Also what about the spawns I mentioned?
"The demand for free goods is infinite."
0

#9 User is offline   sanctum32 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 118
  • Joined: 28-November 10
  • Gender:Male

Posted 26 August 2011 - 03:31 PM

about spawns, no... i checked these old coords too, it simply adds creatures inside of cave (it is related to db development), whydb has it, anyway arcemu will not lose nothing if these will removed.
by xsavior (ACID project) comments, probably some of them can be spawned near ship (patrols for cannon event) after some bosses death, but i'm not sure, that need to add it as this way.

basically i'm not usre as well, but thinking to add them on cannon activate event (when full cannon event will finished - working with when getting free time).
Posted Image
Posted Image
Sorry for my bad english
0

#10 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 27 August 2011 - 05:11 PM

OK I understand.
I've just finished testing it all, it seems to be working fairly fine.
However Gilnid doesn't seem to be casting, I will have to investigate what is wrong there :\

EDIT:
OK I see you kinda fixed Gilnid. However now I can see that he spams the spell without cooldown or cast time.
After some investigation it seems to be ( partly ) because you overrode the cooldowns in the ai_agents table to 0 in most case ( cooldown_overwrite field ).
Also I can see that in most cases you overrode the target types too.
I feel there's lots of work to be done here still....

I am going to ask you NOT to submit patches until they are properly tested and you are sure they work at least as well as the code BEFORE applying your patch.
This way this is REALLY more trouble than worth... Patches are supposed to help us, not give us more problems.
In any way I appreciate the intention to help, but intentions are NOT enough unfortunately.

Either way I will finish reviewing, and fixing this patch and will apply it when done.

EDIT:
Some other issues

Quote

Query : -- Defias Taskmaster (author: whydb) delete from creature_ai where entry=4417

Error Code : 1146
Table 'aworld.creature_ai' doesn't exist


Also you added spell 4208 ( no such spell ) instead of 5208 ( Poisoned Harpoon ) to Captain Greenskin :\

Such a small patch and yet so many issues.................. :/

EDIT:
You also added a crash :\

Original:
				MoonScriptCreatureAI* Guard = NULL;
				for(int x = 0; x < 2; x++)
				{
					Guard = SpawnCreature(636);
					if(Guard == NULL)
						continue;
					Guard->SetDespawnWhenInactive(true);
					Guard->GetUnit()->m_noRespawn = true;
					Guard = NULL;
				}


Your version:
			for(int x = 0; x < 2; x++)
			{
				MoonScriptCreatureAI* Guard = SpawnCreature(636);
				Guard->SetDespawnWhenInactive(true);
				Guard->GetUnit()->m_noRespawn = true;
			}


As you can see your version is missing a NULL check. If SpawnCreature returns NULL, the script will crash and it will take the server with it...

( fixed it already btw, just posting it for the record )
"The demand for free goods is infinite."
0

#11 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 27 August 2011 - 05:46 PM

- Applied.
- Moved to applied patches.

Just a notice:
This is the last time I am fixing someone's patch.
Be sure to know what you are doing before submitting a patch, and make sure it works, and doesn't add issues!
Otherwise the patch will just be summarily declined!

"The demand for free goods is infinite."
0

#12 User is offline   Zuel 

  • Member
  • Pip
  • Group: Members
  • Posts: 91
  • Joined: 11-November 11
  • Gender:Male
  • Server OS:Windows

Posted 11 November 2011 - 09:24 PM

Hey my Server alrdy Have this , And TY for this Release its heplful for other people :P
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users