ArcEmu: [Applied]Hunter Pet Xp Reset On Dismiss - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied]Hunter Pet Xp Reset On Dismiss

#1 User is offline   Tiramisu 

  • Member
  • Pip
  • Group: Members
  • Posts: 13
  • Joined: 19-June 08

Posted 05 May 2011 - 12:20 PM

Found this issue in rev 4172. Hunter pets lose all their current xp whenever they are dismissed (when the player mounts up, logs out etc).

How to reproduce: Kill something that will reward xp for the pet, open the pet window with ctrl-p and check the xp with mouse over on the pet xp bar, mount up, dismount and check the xp again. Now it's 0.

I noticed that there are plenty of places in different structures/variables used for storing pet xp value in ArcEmu strangely enough. Seems a bit redundant. I don't have time (for now at least) to look further into the reason behind this, so I just tested to sync up the values at 2 points in the code and it seems to work fine after testing a bit. Available time is always a problem so I'm posting this partial work in case someone finds it useful, since I don't know when I get a chance to look further into it myself.

The 2 mods needed in pet.cpp:

1. In Pet::GiveXP
after
SetUInt32Value( UNIT_FIELD_PETEXPERIENCE, xp );
add
m_PetXP = xp;

2. In Pet::LoadFromDB
replace: (row approx: 655)
SetUInt32Value( UNIT_FIELD_PETEXPERIENCE, 0);
with
SetUInt32Value(UNIT_FIELD_PETEXPERIENCE, m_PetXP);
0

#2 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 23 October 2011 - 08:55 AM

I ended up removing m_PetXP and using only UNIT_FIELD_PETEXPERIENCE. Thank you for highlighting the issue and suggesting the fix.
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
0

#3 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 23 October 2011 - 08:56 AM

- Applied.
- Moved to applied patches.
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users