ArcEmu: [Applied]Item Flags - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Applied]Item Flags Fixes some enums, new flags and flags2

#1 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 18 December 2010 - 07:00 AM

Patch Title: Item flags

What does this patch fix: At first I've updated enum with Item Flags (they were old/not correct). Then I've started to implementing some of those item flags and found, that column Faction in items table (added somewhere aroud 3.3.0) should be rather called flags2, so I've added enum for them too (thanks MaNGOS).

Newly implemented flags:
  • ITEM_FLAG_INDESTRUCTIBLE
  • ITEM_FLAG_FREE_FOR_ALL
  • ITEM_FLAG_USEABLE_IN_ARENA
  • ITEM_FLAG2_HORDE_ONLY
  • ITEM_FLAG2_ALLIANCE_ONLY
  • ITEM_FLAG2_EXT_COST_REQUIRES_GOLD


A part of ITEM_FLAG_FREE_FOR_ALL is removing ffa_loot columns, which are now useless, since ffa is checked from item flags.

How to reproduce?
ITEM_FLAG_INDESTRUCTIBLE - get any of shaman's totem and try to destroy it.
ITEM_FLAG_FREE_FOR_ALL - make group of at least 2 people, spawn creature/go which has in loot item, which is ffa, kill/open go, loot teh item with 1 person and then try to loot same item with second person.
ITEM_FLAG_USEABLE_IN_ARENA - http://www.wowhead.c...155;crs=1;crv=0 these are only items usable in arena. try to get any other consumable item and use it during arena match.
ITEM_FLAG2_HORDE_ONLY + ITEM_FLAG2_ALLIANCE_ONLY - SELECT * FROM `items` WHERE `flags2` & 1; checks in database for horde items only, then you may try to add any of those items to any creature's loot (with 100% chance) and try to kill & loot this creature with ally player. You should never get this item.
ITEM_FLAG2_EXT_COST_REQUIRES_GOLD - This fixes weird thing about extended costs. There are many items which have normal buyprice and 2 vendors are selling them. First on retail should sells this item just for money and second just for extended cost. Current problem is that normal buyprice is added to every vendor, so second vendor will sell this item for extended cost + money. This flag however marks those items, which should use both extended cost and money for selling (like this http://www.wowhead.com/item=17348).

Attached File(s)


Posted Image
0

#2 User is offline   Shauren 

  • Helper
  • Group: Contributor
  • Posts: 808
  • Joined: 04-November 08
  • Gender:Male
  • Location:Poland
  • Interests:hmm, wow?

Posted 18 December 2010 - 05:59 PM

as a matter of fact mangos 'stole' this from trinitycore without credits

but its not really important
0

#3 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 19 December 2010 - 07:57 AM

View PostShauren, on 18 December 2010 - 05:59 PM, said:

as a matter of fact mangos 'stole' this from trinitycore without credits

but its not really important


I hoped 'stole' wars are out. As it seems they aren't.
Posted Image
0

#4 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 19 December 2010 - 01:44 PM

I think I said this a few times but let me say it again, just show me what needs to be copy&pasted and I can do that too :)
"The demand for free goods is infinite."
0

#5 User is offline   SB@L 

  • ArcEmu lover
  • PipPipPipPip
  • Group: Developers
  • Posts: 616
  • Joined: 12-June 08
  • Gender:Male
  • Location:Slovakia

Posted 19 December 2010 - 02:32 PM

Could itm.ffa_loot be changed from uint32 to bool?
SQL scripts: To remove pet spells from player
CRASH REPORTING TUTORIAL
TIP: If your core crashes on startup, its probably an outdated DB, apply recent sql updates.
0

#6 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 19 December 2010 - 04:31 PM

View PostSB@L, on 19 December 2010 - 02:32 PM, said:

Could itm.ffa_loot be changed from uint32 to bool?

Why would we want to do that?
Doesn't the loot packet use uint32?

If you are trying to save 3 bytes and 7 bits, it's not gonna work because of alignment you will still lose those most likely.
"The demand for free goods is infinite."
0

#7 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 19 December 2010 - 05:01 PM

View Postdfighter, on 19 December 2010 - 01:44 PM, said:

I think I said this a few times but let me say it again, just show me what needs to be copy&pasted and I can do that too :D


Then you may proly go trough mangos and trinity and update all our old enums. Some of them are were old and even not used sometimes. But well, I am just trying to save you a little bit of time :).
Posted Image
0

#8 User is offline   SB@L 

  • ArcEmu lover
  • PipPipPipPip
  • Group: Developers
  • Posts: 616
  • Joined: 12-June 08
  • Gender:Male
  • Location:Slovakia

Posted 20 December 2010 - 03:43 AM

View Postdfighter, on 19 December 2010 - 04:31 PM, said:

Why would we want to do that?
Doesn't the loot packet use uint32?

If you are trying to save 3 bytes and 7 bits, it's not gonna work because of alignment you will still lose those most likely.

Then use one uint32 value for flags and ffa would be one of them...
SQL scripts: To remove pet spells from player
CRASH REPORTING TUTORIAL
TIP: If your core crashes on startup, its probably an outdated DB, apply recent sql updates.
0

#9 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 23 October 2011 - 08:14 AM

Any other response?
Posted Image
0

#10 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 12 November 2011 - 05:54 PM

- Applied.
- Moved to applied patches.
"The demand for free goods is infinite."
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users