ArcEmu: Rev 3376 Small Optimization - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Developing

Interesting in developing with us? Join us on IRC: irc.emulationnetwork.com:6667 #arcemu
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Rev 3376 Small Optimization

#1 User is offline   Andy_ 

  • Universal Cock Master
  • PipPip
  • Group: Developers
  • Posts: 128
  • Joined: 02-September 08
  • Gender:Male

Posted 02 June 2010 - 05:34 AM

Just this :D

62 virtual bool CheckClassMask(Unit *victim, SpellEntry *CastingSpell)
63 {
64 if( ( mProcClassMask[0] == 0 && mProcClassMask[1] == 0 && mProcClassMask[2] == 0 )||
65 mProcClassMask[0] & CastingSpell->SpellGroupType[0] ||
66 mProcClassMask[1] & CastingSpell->SpellGroupType[1] ||
67 mProcClassMask[2] & CastingSpell->SpellGroupType[2] )
68 return true;
69 else
70 return false;
71 }


Could just be:

return ((mProcClassMask[0] & CastingSpell->SpellGroupType[0]) | (mProcClassMask[1] & CastingSpell->SpellGroupType[1]) | (mProcClassMask[2] & CastingSpell->SpellGroupType[2]));

And you have 0 logic branches (vs the 8-9 that are there now).
0

#2 User is offline   Hoffa 

  • Sup dawg
  • Group: Retired
  • Posts: 1,159
  • Joined: 11-December 08
  • Gender:Male
  • Location:Sweden
  • Interests:Trolling

Posted 02 June 2010 - 09:17 AM

bump :3
Posted ImagePosted Image



This person is known for trolling, flaming and extreme ignorance. Respond to at own risk.
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users