ArcEmu: Item - Shadowmourne Legendary - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Item - Shadowmourne Legendary When you have acquired 10 Soul Fragments you will unleash Chaos Bane

#1 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 02 April 2010 - 08:52 AM

I have added this in
SpellAuras.cpp
		
	case 71903: // SM-Effect
		{
			if(GetCaster()->IsPlayer())
			{
				if(!apply)
				{
					TO_PLAYER(GetCaster())->RemoveAura(71905);
					TO_PLAYER(GetCaster())->RemoveAura(72521);
					TO_PLAYER(GetCaster())->RemoveAura(72523);
				}
			}
		}break;

	case 71905: // ShadowMourne-Shards
		{
			if(GetCaster()->IsPlayer())
			{
				Player* plr = TO_PLAYER(GetCaster());
				if(apply)
				{
					SetDuration(60000); // Stack 
					if(plr->GetAuraStackCount(71905) < 5)
					{
						plr->RemoveAura(72523);
						if(!plr->HasAura(72521))
							plr->CastSpell(plr, 72521, false);
					}
					if(plr->GetAuraStackCount(71905) >=6 )
					{
						plr->RemoveAura(72521);
						if(!plr->HasAura(72523))
							plr->CastSpell(plr, 72523, false);						
					}
					if(plr->GetAuraStackCount(71905) >= 10 )
					{
						SpellEntry* sp = dbcSpell.LookupEntry(71904);
						plr->CastSpellAoF(plr->GetPositionX(), plr->GetPositionY(), plr->GetPositionZ(), sp, false);
						plr->RemoveAura(72521);
						plr->RemoveAura(72523);
						plr->RemoveAura(71905); //SHOULD REMOVE ALL for now only removing one, had it hackfixed with multilple removeauras
					}
				}
				else
				{
					plr->RemoveAura(72521);
					plr->RemoveAura(72523);
				}
			}
		}break;
}
 	




 		}



and added to
SpellFixes.cpp


  			//ADDED DJHENGHIZ
			
		sp = dbcSpell.LookupEntry(71903); // ShadowMourne Effect
		if(sp != NULL)
				{
					sp->Effect[0] = SPELL_EFFECT_APPLY_AURA;
					sp->EffectApplyAuraName[0] = SPELL_AURA_DUMMY;
					sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_PHYSICAL_ATTACK | PROC_ON_CRIT_ATTACK;
					sp->procChance = 20;
					sp->Effect[1] = SPELL_EFFECT_APPLY_AURA;
					sp->EffectApplyAuraName[1] = SPELL_AURA_PROC_TRIGGER_SPELL;
					sp->EffectTriggerSpell[1] = 71905;
				}

		sp = dbcSpell.LookupEntry(71905); // ShadowMourne Effect
		if(sp != NULL)
				{
					sp->Effect[1] = SPELL_EFFECT_APPLY_AURA;
					sp->EffectApplyAuraName[1] = SPELL_AURA_DUMMY;
				}




Seems to work just fine, only problem is it should be removed after casting chaos bane, that removeaura should remove, that is beeing worked on so i would like some input on the other parts of the script, if that can be done better. Or maybe like darkgroom suggested move it into itemspells1.cpp ?

FEEL FREE TO IMPROVE ADJUST xD would be nice to have it bugfree on svn.. i just want it soooo bad xD

This post has been edited by Dzjhenghiz: 02 April 2010 - 12:22 PM

Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#2 User is offline   Shadoxfix 

  • Enthusiast
  • PipPipPip
  • Group: Members
  • Posts: 312
  • Joined: 30-December 09
  • Gender:Male
  • Location:Netherlands

Posted 02 April 2010 - 10:24 AM

Shadowmourne isn't obtainable by players right?
0

#3 User is offline   Fyurie 

  • Member
  • Group: Supporter
  • Posts: 31
  • Joined: 19-April 09
  • Gender:Male
  • Location:London

Posted 02 April 2010 - 10:27 AM

It is, it's a quest chain involving ICC25.
0

#4 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 02 April 2010 - 10:39 AM

correct : http://www.wowhead.com/?quest=24549
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#5 User is offline   alleycat 

  • Helps so much & is so mature & gay
  • PipPipPipPipPip
  • Group: Members
  • Posts: 835
  • Joined: 25-July 08
  • Gender:Male

Posted 02 April 2010 - 11:05 AM

I don't like this fix. The shadowmourne effect (71903) is already a dummy (Effect[0] = 6, ApplyAura[0] = 4), it already has a 100% proc chance with procflags 20 which includes physical hit. Not only that, the dummy handler for 71903 should cast 71905, not some hack fix trigger spell. Also, there are simple ways to remove a stack of auras, so I dislike your single remove.
I can haz cookie?
0

#6 User is offline   Darren 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 104
  • Joined: 18-June 08

Posted 02 April 2010 - 11:17 AM

It already is in the workshop xD
0

#7 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 02 April 2010 - 12:24 PM

Quote

Also, there are simple ways to remove a stack of auras, so I dislike your single remove.



idk i just made a head start xD feel free to improve, and the removeauras() will be working shortly hopefully too so simple enough imo ?
I aint a coder Alleycat as you might know by know, so plox fix ? xD


Would be great to have it working without issues xD
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#8 User is offline   Shauren 

  • Helper
  • Group: Contributor
  • Posts: 808
  • Joined: 04-November 08
  • Gender:Male
  • Location:Poland
  • Interests:hmm, wow?

Posted 02 April 2010 - 03:34 PM

actually chaos bane works slightly different - when you have 10 stacks it doesnt automatically unleash it but its triggered on next melee
0

#9 User is offline   alleycat 

  • Helps so much & is so mature & gay
  • PipPipPipPipPip
  • Group: Members
  • Posts: 835
  • Joined: 25-July 08
  • Gender:Male

Posted 02 April 2010 - 06:11 PM

Which makes sense.
I can haz cookie?
0

#10 User is offline   dfighter 

  • Titles are overrated
  • PipPipPipPipPipPipPipPipPipPip
  • Group: Administrator
  • Posts: 5,189
  • Joined: 14-June 08
  • IRC:dfighter
  • Gender:Male
  • Server OS:Linux

Posted 02 April 2010 - 08:55 PM

Dzjhenghiz instead of

plr->RemoveAura(71905); //SHOULD REMOVE ALL for now only removing one, had it hackfixed with multilple removeauras


do

plr->RemoveAllAuraById(71905);

"The demand for free goods is infinite."
0

#11 User is offline   alleycat 

  • Helps so much & is so mature & gay
  • PipPipPipPipPip
  • Group: Members
  • Posts: 835
  • Joined: 25-July 08
  • Gender:Male

Posted 02 April 2010 - 10:23 PM

Yup
I can haz cookie?
0

#12 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 03 April 2010 - 02:55 AM

View Postdfighter, on 02 April 2010 - 08:55 PM, said:

Dzjhenghiz instead of

plr->RemoveAura(71905); //SHOULD REMOVE ALL for now only removing one, had it hackfixed with multilple removeauras


do

plr->RemoveAllAuraById(71905);




thanks Dfighter xD
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#13 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 03 April 2010 - 03:53 PM

So i updated it : and gonna test it locally on some mobs xD



Index: src/arcemu-world/SpellAuras.cpp
===================================================================
--- src/arcemu-world/SpellAuras.cpp	(revision 3251)
+++ src/arcemu-world/SpellAuras.cpp	(working copy)
@@ -2733,6 +2733,55 @@
 					caster->m_soulSiphon.amt-= mod->m_amount;
 			}
 		}break;
+	  case 71903: // SM-Effect
+                {
+                        if(GetCaster()->IsPlayer())
+                        {
+                                if(!apply)
+                                {
+                                        TO_PLAYER(GetCaster())->RemoveAura(71905);
+                                        TO_PLAYER(GetCaster())->RemoveAura(72521);
+                                        TO_PLAYER(GetCaster())->RemoveAura(72523);
+                                }
+                        }
+                }break;
+
+        case 71905: // ShadowMourne-Shards
+                {
+                        if(GetCaster()->IsPlayer())
+                        {
+                                Player* plr = TO_PLAYER(GetCaster());
+                                if(apply)
+                                {
+                                        SetDuration(60000); // Stack 
+                                        if(plr->GetAuraStackCount(71905) < 5)
+											{
+                                                plr->RemoveAura(72523);
+                                                if(!plr->HasAura(72521))
+                                                        plr->CastSpell(plr, 72521, false);
+											}
+						if(plr->GetAuraStackCount(71905)>=6 && plr->GetAuraStackCount(71905) <10 )
+											{
+                                                plr->RemoveAura(72521);
+                                                if(!plr->HasAura(72523))
+                                                        plr->CastSpell(plr, 72523, false);                                              
+											}
+                                        if(plr->GetAuraStackCount(71905) >= 10 )
+											{
+                                                SpellEntry* sp = dbcSpell.LookupEntry(71904);
+                                                plr->CastSpellAoF(plr->GetPositionX(), plr->GetPositionY(), plr->GetPositionZ(), sp, false);
+                                                plr->RemoveAllAuraById(71905); //Thanks Dfighter
+												plr->RemoveAura(72521);
+                                                plr->RemoveAura(72523);
+											}
+                                }
+                                else
+                                {
+                                        plr->RemoveAura(72521);
+                                        plr->RemoveAura(72523);
+                                }
+                        }
+                }break;
 	}
 	
 	Unit * caster = GetUnitCaster();
Index: src/arcemu-world/SpellFixes.cpp
===================================================================
--- src/arcemu-world/SpellFixes.cpp	(revision 3251)
+++ src/arcemu-world/SpellFixes.cpp	(working copy)
@@ -8421,6 +8421,27 @@
 			sp->procChance = 100;
 		}
 
+//ADDED DJHENGHIZ
+                        
+		sp = dbcSpell.LookupEntry(71903); // ShadowMourne Effect
+		if(sp != NULL)
+		{
+			sp->Effect[0] = SPELL_EFFECT_APPLY_AURA;
+			sp->EffectApplyAuraName[0] = SPELL_AURA_DUMMY;
+			sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_PHYSICAL_ATTACK | PROC_ON_CRIT_ATTACK;
+			sp->procChance = 20;
+			sp->Effect[1] = SPELL_EFFECT_APPLY_AURA;
+			sp->EffectApplyAuraName[1] = SPELL_AURA_PROC_TRIGGER_SPELL;
+			sp->EffectTriggerSpell[1] = 71905;
+		}
+
+			sp = dbcSpell.LookupEntry(71905); // ShadowMourne Effect
+			if(sp != NULL)
+		{
+			sp->Effect[1] = SPELL_EFFECT_APPLY_AURA;
+			sp->EffectApplyAuraName[1] = SPELL_AURA_DUMMY;
+		}
+
 		//Tempfix for Stone Statues
 		sp = dbcSpell.LookupEntryForced( 32253 );
 		if( sp != NULL )



[attachment=2400:shadowmourne.patch]


@Alleycat idk if its possible to script the dummyspell part it in itemspells1.cpp ?
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#14 User is offline   Akamaran 

  • Member
  • Pip
  • Group: Members
  • Posts: 56
  • Joined: 26-August 08
  • Gender:Male
  • Location:Canada

Posted 15 August 2010 - 11:02 PM

This is quite and old post but i was wondering if the last update Dzjhenghiz created if it worth commiting. Just an idea to make the spell actually work.

Regards,
Akamaran
0

#15 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 24 August 2010 - 04:05 AM

You could have post your version here too instead of making new topic :rolleyes:
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

#16 User is offline   Dzjhenghiz 

  • حشّاشين
  • Group: Contributor
  • Posts: 1,936
  • Joined: 07-June 08
  • Gender:Male
  • Location:2nd stone after the 3rd oase western sahara
  • Interests:M.C.S.E :- Minesweeper Consultant & Solitaire Expert
  • Server OS:Other

Posted 23 March 2011 - 06:34 AM

again some one "trying to fix" this ;

Look look
Need Help With Arcemu ? ^^
Posted Image
Concordia res parvae crescunt In varietate concordia
Spoiler

0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users