ArcEmu: Core Development: Quest System - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Read:

When submitting patches - READ: http://arcemu.org/fo...?showtopic=2355 -
  • (5 Pages)
  • +
  • « First
  • 3
  • 4
  • 5
  • You cannot start a new topic
  • You cannot reply to this topic

Core Development: Quest System

#81 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 21 August 2011 - 07:23 PM

Seriously, 45 KB of patch (even zipped!!!) all at once? Is there really no way to split it so there's a chance I'll remember what I'm reviewing? Was it really needed to change areatriggers, too, in this patch?
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
0

#82 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 04 September 2011 - 11:24 AM

View PostSadikum, on 11 August 2010 - 07:36 AM, said:

Now areatriggers type are flag because they can be a teleport trigger and a quest trigger (like Deadmines entrance trigger)

https://sourceforge....AreaTrigger.cpp
void WorldSession::_HandleAreaTriggerOpcode(uint32 id)
{
    LOG_DEBUG("AreaTrigger: %u", id);
    // Are we REALLY here?
    if(!_player->IsInWorld())
        return;
    // Search quest log, find any exploration quests
    sQuestMgr.OnPlayerExploreArea(GetPlayer(), id);

sQuestMgr.OnPlayerExploreArea() is called always right now, regardless of the areatrigger type so the case "teleport+quest" trigger is already covered.

View PostSadikum, on 11 August 2010 - 07:36 AM, said:

or inn and quest trigger (world_quest_system.sql have been updated to update your database correctly).

same as above, so looks like the changes of how area triggers are handled are not really needed. Feel free to post it in another patch, specifying cases where it's really needed.

patch for r3602
http://pozzoni4.inte...tSystem3602.rar

removed the changes in Creature.cpp of https://sourceforge..../changeset/4518 and the unneeded codestyle changes.
http://pozzoni4.inte...ystem3602v2.rar

removed from MiscHandler.cpp the changes added in https://sourceforge..../changeset/3932
http://pozzoni4.inte...ystem3602v3.rar

there's a + void LoadQuestPOI(); in ObjectMgr.h but it's not defined anywhere, just declared. Removed anyway as it was implemented in https://sourceforge..../changeset/3812
http://pozzoni4.inte...ystem3602v4.rar

removed changes in Player.h, Player.cpp, Quest.h, Quest.cpp, QuestMgr.h, QuestMgr.cpp about timed quests and failed state since they were implemented in https://sourceforge..../changeset/4474
https://sourceforge..../changeset/4475
https://sourceforge..../changeset/4476
https://sourceforge..../changeset/4479
http://pozzoni4.inte...ystem3602v5.rar

finished removing all the codestyle changes and checked all modified files, there shouldn't be any more fetures already implemented in r4520 (current).
http://pozzoni4.inte...ystem3602v6.rar (36KB of rar, was around 41KB when I started reviewing)

updated to r3682 (it's gonna take a while to update it in revision ranges to be able to solve conflicts...)
http://pozzoni4.inte...ystem3682v6.rar

lul at QUESY_SHARE_MSG_DIFFERENT_SERVER_DAILY , 1 year and half old typo^^ (never heard of quesY before)

updated to r3755 (there were some quest fixes in these revisions)
http://pozzoni4.inte...tSystem3755.rar
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
1

#83 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 05 September 2011 - 01:47 PM

Well, thanks for reviewing the patch finally after 1 and half year. Do you still need to split patch? Maybe you can make branch where you can apply it by small pieces, I've even found some smaller things in it, but seriously can't remember them after year.
Posted Image
0

#84 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 10 September 2011 - 01:59 PM

So far I removed from the patch features that have been implemented lately, removed all the codestyle changes (so I can focus on the lines that change functionalities) and then started updating it rev by rev, fixing conflicts. When it will be updated to a recent revision (probably before Hurricane Andy applied his codestyle stuff), I'll review and apply feature by feature, each one with 1 commit. So yeah, in a sense I still need to split it but I may even do it on my own. Any help is welcome, tho :)

updated to r3800 (note: before uploading here the updated patch I test the build but obviously don't test it ingame. it could even be that due to db structure changes it doesn't even start).
http://pozzoni4.inte...tSystem3800.rar

updated to r3807 (QuestXP.dbc support was added in that revision)
http://pozzoni4.inte...tSystem3807.rar

updated to r3900
http://pozzoni4.inte...tSystem3900.rar
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
1

#85 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 08 October 2011 - 02:21 PM

as spotted by http://arcemu.org/fo...showtopic=25613 , qst->bonusarenapoints is only sent to the client but the arena points are never added to the player.

updated to r3950
http://pozzoni4.inte...tSystem3950.rar

updated to r4050
http://pozzoni4.inte...tSystem4050.rar

updated to r4105
http://pozzoni4.inte...tSystem4105.rar

updated after r4630 "added bonusarenapoints support to quests"
http://pozzoni4.inte...ystem4105v2.rar

I was checking the MailTemplate.dbc support ( http://pastebin.com/UYUQi6TR updated to latest rev with only the diff required to support that dbc) but the mail is sent with
sMailSystem.SendAutomatedMessage( NORMAL, qst_giver->GetGUID(), plr->GetGUID(), mail->subject, mail->content, 0, 0, 0, MAIL_STATIONERY_TEST1, qst->MailDelaySecs );

is it supposed to be sent with type set to NORMAL ? is this blizzlike? In case quest giver is a Creature, doesn't it make more sense to send it with type set to CREATURE? same goes for GameObject quest givers.
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
1

#86 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 13 October 2011 - 10:32 AM

Hey, thanks for applying at least some parts of my patch :D

- about that mail sending, I am not sure, why I did that, it might be only a typo but I really can't remember it, it's already 1 and half year ago ;)

- about arena points, I think there are no quests with value higher then 0 for this field, so that's maybe why I left it unused (as far as I can remember Trinity or Mangos didn't have this implemented too).

I am sorry I can't currently spend so much time here or testing because of job, but I will try to help you as much as possible (but better will be when you need something, ask me directly trough PM or even better directly on my email)

Thanks!
Posted Image
0

#87 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 14 October 2011 - 05:27 PM

tried with http://old.wowhead.com/quest=1141 after I fixed the mail type, but now another question pops up: shouldn't the mail have some kind of item, too? maybe the quest reward item? how does it work on retail?

Ss from trinity: http://imageshack.us...1411143224.jpg/
They should have a table with "entry of mailtemplate.dbc + item", so this part of your patch is incomplete.

the work so far on the quest mail part: http://pastebin.com/53hMa7bw

quest patch (the big one) updated removing the code related to the quest mail part
http://pozzoni4.inte...ystem4105v3.rar

took a look at monster say events when quest starts/finishes ( http://pastebin.com/0isj2Lsy ) , shouldn't the chat message be sent only to the player that started/finished the quest?
Edit: according to dfighter the chat message is sent to all players. Anyway shouldn't at least be bound to a quest id? are there cases of npcs with multiple quests that send chat messages only for some of those quests?
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
0

#88 User is offline   MesoX 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 296
  • Joined: 15-June 08
  • Gender:Male
  • Location:Czech Republic
  • Interests:pc & girls & parties

Posted 19 October 2011 - 09:09 AM

Then it will mean expanding npc_monstersay table :) I think that changing that table with new possibilities may come later, as a part of easy script engine using ai_agents for actions and this for speaking
Posted Image
0

#89 User is offline   jackpoz 

  • ArcEmu Lemon Priest
  • PipPipPipPipPipPipPipPip
  • Group: Developers
  • Posts: 2,153
  • Joined: 19-June 08
  • Gender:Male
  • Location:Italy
  • Server OS:Windows

Posted 22 October 2011 - 05:03 AM

moved the quest mail part to http://arcemu.org/fo...showtopic=25696

moved the monster say part to http://arcemu.org/fo...showtopic=25697

quest patch updated removing the mentioned above features http://pozzoni4.inte...ystem4105v4.rar
Posted Image We develop dreams. Your dreams ;)
Posted ImagePosted Image
0

Share this topic:


  • (5 Pages)
  • +
  • « First
  • 3
  • 4
  • 5
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users