[dark alex ~ BAWoW]

With this Patch a Player gets the messagt that his prepaid account has run out of gametime if you set banned to 2.

Diff Patch

Index: src/arcemu-logonserver/AuthSocket.cpp
===================================================================
--- src/arcemu-logonserver/AuthSocket.cpp (revision 2316)
+++ src/arcemu-logonserver/AuthSocket.cpp (working copy)
@@ -208,6 +208,11 @@
SendChallengeError(CE_ACCOUNT_CLOSED);
return;
}
+ else if(m_account->Banned == 2)
+ {
+ SendChallengeError(CE_PREORDER_TIME_LIMIT);
+ return;
+ }
else if(m_account->Banned > 0)
{
SendChallengeError(CE_ACCOUNT_FREEZED);
@@ -590,6 +595,11 @@
SendChallengeError(CE_ACCOUNT_CLOSED);
return;
}
+ else if(m_account->Banned == 2)
+ {
+ SendChallengeError(CE_PREORDER_TIME_LIMIT);
+ return;
+ }
else if(m_account->Banned > 0)
{
SendChallengeError(CE_ACCOUNT_FREEZED);
Index: src/arcemu-logonserver/AccountCache.cpp
===================================================================
--- src/arcemu-logonserver/AccountCache.cpp (revision 2316)
+++ src/arcemu-logonserver/AccountCache.cpp (working copy)
@@ -108,19 +108,19 @@
acct->AccountId = field[0].GetUInt32();
acct->AccountFlags = field[5].GetUInt8();
acct->Banned = field[6].GetUInt32();
- if ( (uint32)UNIXTIME > acct->Banned && acct->Banned != 0 && acct->Banned != 1) //1 = perm ban?
+ if ( (uint32)UNIXTIME > acct->Banned && acct->Banned != 0 && acct->Banned > 3) //1 = perm ban?
{
//Accounts should be unbanned once the date is past their set expiry date.
acct->Banned = 0;
//me go boom
- //printf("Account %s's ban has expired.\n",acct->UsernamePtr->c_str());
+ printf("Account %s's ban has expired.\n",acct->UsernamePtr->c_str());
sLogonSQL->Execute("UPDATE accounts SET banned = 0 WHERE acct=%u",acct->AccountId);
}
acct->SetGMFlags(GMFlags.c_str());
- acct->Locale[0] = 'e';
- acct->Locale[1] = 'n';
- acct->Locale[2] = 'U';
- acct->Locale[3] = 'S';
+ acct->Locale[0] = 'e';
+ acct->Locale[1] = 'n';
+ acct->Locale[2] = 'U';
+ acct->Locale[3] = 'S';
if(strcmp(field[7].GetString(), "enUS"))
{
// non-standard language forced
@@ -201,12 +201,12 @@
acct->AccountId = field[0].GetUInt32();
acct->AccountFlags = field[5].GetUInt8();
acct->Banned = field[6].GetUInt32();
- if ((uint32)UNIXTIME > acct->Banned && acct->Banned != 0 && acct->Banned != 1) //1 = perm ban?
+ if ((uint32)UNIXTIME > acct->Banned && acct->Banned != 0 && acct->Banned > 3) //1 = perm ban?
{
- //Accounts should be unbanned once the date is past their set expiry date.
- acct->Banned = 0;
+ //Accounts should be frozen once the date is past their set expiry date.
+ acct->Banned = 2;
sLog.outDebug("Account %s's ban has expired.",acct->UsernamePtr->c_str());
- sLogonSQL->Execute("UPDATE accounts SET banned = 0 WHERE acct=%u",acct->AccountId);
+ sLogonSQL->Execute("UPDATE accounts SET banned = 2 WHERE acct=%u",acct->AccountId); //expired ban -> freeze Account
}
acct->SetGMFlags(GMFlags.c_str());
if(strcmp(field[7].GetString(), "enUS"))

Btw: when a ban expires the account will get frozen with that patch. To change that see the comment in the patch!

[Kenjiro]

Good work, but please do not change default locale definition.

[dark alex ~ BAWoW]

Oh shit sry I wanted to change that as I do not know much about patches and I wrote the wrong into it sorry fixing it asap

[Egari]

Doesn't this basically turn temporary bans into a permanent bans?

[dark alex ~ BAWoW]

no. just if numbers are <= 3 it will result in not being changed. (3 is not specially used atm but I reserved it for my Server so you could change the SQL-Query to check against >2 instead of >3 but that doesn't matter here...



Oh you meant that part...

No! Wehn a ban expires it will be changed to frozen account. So you should allow the user to reenable the account through webinterface. (set banned-Field on 0 to unban/unfreeze)


Values for Table-Field banned:
0 = Active
1 = Perm. Banned
2 = Frozen
3 = Not used, so its Perm Ban, too
>3 = Temp. Ban which changes to Frozen after bantime runs out.

[Andy_]

Why would you even want this error message?

[dark alex ~ BAWoW]

I use it for my Accountmanager to give users the option to disable their account and there I don't want to have the BANNED-Message

[Terrorblade]

or for servers who have "VIP" this would be useful

[Hopla]

Have you considered instead of setting banned using use a timeformat to deactivate the account?

[fleshripper]

Wouldnt it be ideal instead of using banned.. just make another fieldname in the account database? - just a suggestion