ArcEmu: [Patch[ Quest Complete generates SQL err - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Patch[ Quest Complete generates SQL err You have an error in your SQL syntax

#1 User is offline   Darvaleo 

  • Member
  • Pip
  • Group: Members
  • Posts: 36
  • Joined: 09-June 08

Posted 22 March 2009 - 12:56 PM

When using .quest complete [A Quest Name Here] instead of the quest id, a SQL error appears on the arcemu-world.exe console:

Quote

query failed due to
[You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version for the right syntax to use near '|c8080|Hquest:11216:70|h[Archmage Alturus]|h|r' at line 1],

Query: [SELECT id FROM creature_quest_starter WHERE quest = |cff808080|Hquest:11216:70|h[Archmage Als]|h|r]


Here's the text for the patch:
Diff Patch
Index: src/arcemu-world/QuestCommands.cpp
===================================================================
--- src/arcemu-world/QuestCommands.cpp (revision 2356)
+++ src/arcemu-world/QuestCommands.cpp (working copy)
@@ -340,7 +340,7 @@
uint32 giver_id = 0;
std::string my_query = "";

- my_query = "SELECT id FROM creature_quest_starter WHERE quest = " + string(args);
+ my_query = "SELECT id FROM creature_quest_starter WHERE quest = " + MyConvertIntToString(quest_id);
QueryResult *creatureResult = WorldDatabase.Query(my_query.c_str());

if(creatureResult)
@@ -351,7 +351,7 @@
}
else
{
- my_query = "SELECT id FROM gameobject_quest_starter WHERE quest = " + string(args);
+ my_query = "SELECT id FROM gameobject_quest_starter WHERE quest = " + MyConvertIntToString(quest_id);
QueryResult *objectResult = WorldDatabase.Query(my_query.c_str());
if(objectResult)
{
@@ -384,9 +384,7 @@
if(quest_giver)
{
GreenSystemMessage(m_session, "Found a quest_giver creature.");
- //WorldPacket data;
- //sQuestMgr.BuildOfferReward(&data, qst, quest_giver, 1);
- //m_session->SendPacket(&data);
+ sQuestMgr.OnActivateQuestGiver(quest_giver, plr);
sQuestMgr.GiveQuestRewardReputation(plr, qst, quest_giver);
}
else
@@ -394,6 +392,7 @@
}

sQuestMgr.GenerateQuestXP(plr, qst);
+ sQuestMgr.GenerateRewardMoney(plr, qst);
sQuestMgr.BuildQuestComplete(plr, qst);

IsPlrOnQuest->Finish();


I added the following line for my personal use because I use it for .quest complete, but it is not necessary to fix the SQL error on the console:
sQuestMgr.OnActivateQuestGiver(quest_giver, plr);


Attached is the patch to fix it.

Attached File(s)


0

#2 User is offline   Kenjiro 

  • Enthusiast
  • PipPipPip
  • Group: Members
  • Posts: 311
  • Joined: 12-June 08
  • Location:Poland

Posted 22 March 2009 - 03:53 PM

Yeah, nice work.
Could You also fix other informational messages ? :P Thanks.
0

#3 User is offline   whoami 

  • ArcEmu Lover
  • Group: Retired
  • Posts: 499
  • Joined: 28-August 08
  • Gender:Male

Posted 18 April 2009 - 09:20 AM

This was applied in revision 2466.
0

#4 User is offline   whoami 

  • ArcEmu Lover
  • Group: Retired
  • Posts: 499
  • Joined: 28-August 08
  • Gender:Male

Posted 18 April 2009 - 09:20 AM

- Applied.
- Moved to applied patches.
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users