ArcEmu: Possible Glyph Of Thorns Fix? - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Possible Glyph Of Thorns Fix?

#1 User is offline   WonkyPotato 

  • Member
  • Pip
  • Group: Members
  • Posts: 31
  • Joined: 08-March 11
  • Gender:Male
  • Server OS:Windows

Posted 14 April 2011 - 12:50 AM

The Druid glyph "Glyph of Thorns" does not work. It's intended to increase the spell duration to 50 minutes but it doesn't seem to do anything. I found this possible fix on another website but I don't know much about C++ so I'm hoping maybe someone here can tell me if it looks like it will work or if it needs improvements of any sort before I go editing and recompiling world.exe. Also I read that SpellAuras.cpp is probably not the best place to put this. Any ideas on where it should be placed? Thanks!

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index d196874..e9123ad 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -432,6 +432,32 @@ m_isRemovedOnShapeLost(true), m_in_use(0), m_deleted(false)
         }
     }
 
+    // Handling spell duration modifiers (glyphs for example)
+    switch(m_spellProto->SpellFamilyName)
+    {
+        case SPELLFAMILY_DRUID :
+            // Glyph of thorns
+            switch (m_spellProto->Id)
+            {
+                case 467 :
+                case 782 :
+                case 1075 :
+                case 8914 :
+                case 9756 :
+                case 9910 :
+                case 26992 :
+                case 53307 :
+                    if ((m_caster_guid == m_target->GetGUID()) && (m_target->HasAura(57862)))
+                        m_maxduration += 50*MINUTE*IN_MILLISECONDS;
+                    break;
+                default :
+                    break;
+            }
+            break;
+        default :
+            break;
+    }
+
     if(m_maxduration == -1 || m_isPassive && m_spellProto->DurationIndex == 0)
         m_permanent = true;

0

#2 User is offline   iEzri 

  • < Ace of spades >
  • Group: Contributor
  • Posts: 1,692
  • Joined: 22-December 08
  • Gender:Female
  • Interests:I'm likely to cause mischief
  • Server OS:Linux

Posted 14 April 2011 - 03:14 AM

View PostWonkyPotato, on 14 April 2011 - 12:50 AM, said:

 m_maxduration += 50*MINUTE*IN_MILLISECONDS;



tbh... this looks odd... o.O
Posted Image I do not join. I lead.
0

#3 User is offline   WonkyPotato 

  • Member
  • Pip
  • Group: Members
  • Posts: 31
  • Joined: 08-March 11
  • Gender:Male
  • Server OS:Windows

Posted 14 April 2011 - 04:56 AM

I was thinking maybe that was meant to be replaced with the correct number of milliseconds to equal 50 minutes, such as:

m_maxduration += 3000000;

0

#4 User is offline   WAmadeus 

  • Cunning Code Composer
  • PipPipPip
  • Group: Developers
  • Posts: 287
  • Joined: 23-July 09
  • Gender:Male
  • Location:Brazil

Posted 14 April 2011 - 08:05 AM

lol

Looks like copypasta from Mangos
1

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users