ArcEmu: [Declined]Empowered Frostbolt - ArcEmu

Jump to content

Toggle shoutbox Lastest Announcements

dfighter  : (07 December 2014 - 12:06 PM) Arcemu is in hibernation mode, please read http://arcemu.org/fo...showtopic=26903
dfighter  : (01 January 2013 - 05:56 PM) Arcemu wishes you all a happy new year!
Hasbro  : (12 September 2012 - 10:01 AM) Please excuse our outage from the web! Our web host had a major malfunction!
dfighter  : (01 September 2012 - 04:05 PM) Since the spam bots just don't want to stop, I've enabled admin verification when registering.
dfighter  : (23 January 2012 - 09:56 PM) Please note that from now on you will need to confirm your email on the wiki in order to edit it!
Hasbro  : (31 December 2011 - 12:50 PM) Happy New Years all!
Navid  : (26 December 2011 - 04:09 AM) Merry Christmas !!!!!! Happy holidays all :)
WAmadeus  : (24 December 2011 - 03:54 PM) Merry Christmas to all!
dfighter  : (24 December 2011 - 11:05 AM) The Arcemu team wishes y'all a Merry Christmukkah!
Hasbro  : (05 October 2011 - 12:53 PM) Looking for web designers for upcoming web related project. If you're interested in designing user interfaces contact me
dfighter  : (02 September 2011 - 03:47 PM) So who here wants vehicles in Arcemu? :P http://arcemu.org/fo...showtopic=25440
Hasbro  : (14 August 2011 - 03:25 PM) Join us on irc, grab an irc client and connect to irc.freenode.net join channel #arcemu /server irc.freenode.net:6667 /join #arcemu
jackpoz  : (03 August 2011 - 05:33 AM) to all Lua Engine (old one) users: please check http://arcemu.org/fo...showtopic=25274
Hasbro  : (20 May 2011 - 05:27 PM) Looking for people experienced with CMake configuration and setup! Contact me asap
Hasbro  : (15 May 2011 - 05:03 PM) ArcEmu is recruiting C++ programmers, contact Hasbro if interested.
paroxysm  : (03 May 2011 - 06:26 PM) Updated luabridge gossip example to describe the whole gossip creation process rather than just how to create menu. Gossip tutorial
paroxysm  : (23 April 2011 - 11:35 AM) Lua writers can refer to the Luabridge Tutorials section in the Wiki to learn how to write gossip code correctly.
Hasbro  : (20 April 2011 - 05:22 PM) Thank you for your continuous contribution of bug reports, we are working on them.
Hasbro  : (17 April 2011 - 03:20 AM) Please consider donating to support our bills. Donations can be sent using PayPal to donations@arcemu.org - Thank you for your support.
paroxysm  : (10 April 2011 - 12:43 AM) Refer to the Luabridge Tutorials section in the Wiki to learn the new syntax of luabridge.
Resize Shouts Area

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

[Declined]Empowered Frostbolt

#1 User is offline   Darren 

  • Occasional Poster
  • PipPip
  • Group: Members
  • Posts: 104
  • Joined: 18-June 08

Posted 31 May 2010 - 08:18 AM

Patch Title: Empowered Frostbolt
What bug does this patch fix: Empowered Frostbolt having no effect.
Detailed Explanation: N/A
How to reproduce: Try and use Frostbolt without this talent and note that it does not increase the damage.

Link to thread(s) in bug reports section if available: http://arcemu.org/fo...showtopic=21977
Patch:
Index: SpellEffects.cpp
===================================================================
--- SpellEffects.cpp	(revision 3346)
+++ SpellEffects.cpp	(working copy)
@@ -637,7 +635,22 @@
                                        dmg = dmg >> 1;
                        }
                        break;
+		case SPELL_HASH_FROSTBOLT:
+			{
+				if(p_caster && p_caster->HasAurasWithNameHash(SPELL_HASH_EMPOWERED_FROSTBOLT)) // So that the damage is only modified if the talent is present.
+				{
+					uint32 spellpower = p_caster->GetUInt32Value(PLAYER_FIELD_MOD_DAMAGE_DONE_POS+1);;
+					float plusdmg = 0;
 
+						if(p_caster->HasAura(31682)) // Switch statement or the like seemed kinda redundent.
+							plusdmg = (spellpower * 0.05f);
+						else if(p_caster->HasAura(31683))
+							plusdmg = (spellpower * 0.10f);
+					
+					dmg += float2int32(plusdmg);
+				}
+			}break;
+
 		case SPELL_HASH_EXORCISM:
 		{
 			if( p_caster != NULL )

Attached File(s)


0

#2 User is offline   neatocheeto 

  • Member
  • Group: Banned
  • Posts: 37
  • Joined: 31-May 10
  • Gender:Male

Posted 31 May 2010 - 11:03 AM

Thanks for your time in making this patch.

Is there a tutorial , website , or forum area with instructions on installing

patch files to ArcEmu? Please and Thank you.
Posted Image

#3 User is offline   Andy_ 

  • Universal Cock Master
  • PipPip
  • Group: Developers
  • Posts: 128
  • Joined: 02-September 08
  • Gender:Male

Posted 02 June 2010 - 05:53 AM

This is hacky. Empowered frostbolt uses 2 clear flat modifiers, both should be implemented properly to implement this talent, not by manually modifying the spell if the talent is present.
0

#4 User is offline   WAmadeus 

  • Cunning Code Composer
  • PipPipPip
  • Group: Developers
  • Posts: 287
  • Joined: 23-July 09
  • Gender:Male
  • Location:Brazil

Posted 12 August 2010 - 09:01 AM

This patch has been declined.
Your patch has probably been declined because it either is
1. A hacky fix
2. Not working properly
3. Outdated
4. Incomplete
5. Not a proper patch
Please refer to developer's notes before this post

Feel free to submit another patch when you've corrected/updated it.
0

Share this topic:


Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users